diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2008-12-30 02:49:59 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2009-01-04 03:01:43 +0300 |
| commit | 4dfdc46468a142216b284eea66040f49df3f7191 (patch) | |
| tree | 771f8c4abcecd8e7ac80bc61f97318f24f852fd9 | |
| parent | b8a832b1c0a70531b4bd69a67aa0bf72f6f2dc34 (diff) | |
| download | linux-4dfdc46468a142216b284eea66040f49df3f7191.tar.xz | |
HID: fix error condition propagation in hid-sony driver
sony_set_operational() only propagates return value from
usb_control_msg(), which returns negative on error and number
of transferred bytes otherwise.
Reported-by: Marcin Tolysz <tolysz@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/hid-sony.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 86e563b8d644..dd5a3979a4de 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -102,7 +102,7 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id) } ret = sony_set_operational(hdev); - if (ret) + if (ret < 0) goto err_stop; return 0; |