diff options
| author | Chenwandun <chenwandun@huawei.com> | 2019-10-18 13:20:37 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-10-19 22:16:38 +0300 |
| commit | 3d00cf2fbb61212f47a3cf838be51c921366c937 (patch) | |
| tree | c8b93caf7d572182c09a24b46745ba5a412e4074 | |
| parent | 708738376cadba3ed6cf635a13694951d96a6936 (diff) | |
| download | linux-3d00cf2fbb61212f47a3cf838be51c921366c937.tar.xz | |
net: aquantia: add an error handling in aq_nic_set_multicast_list
add an error handling in aq_nic_set_multicast_list, it may not
work when hw_multicast_list_set error; and at the same time
it will remove gcc Wunused-but-set-variable warning.
Signed-off-by: Chenwandun <chenwandun@huawei.com>
Reviewed-by: Igor Russkikh <igor.russkikh@aquantia.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 2a18439b36fb..137c1de4c6ec 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -664,6 +664,8 @@ int aq_nic_set_multicast_list(struct aq_nic_s *self, struct net_device *ndev) err = hw_ops->hw_multicast_list_set(self->aq_hw, self->mc_list.ar, self->mc_list.count); + if (err < 0) + return err; } return aq_nic_set_packet_filter(self, packet_filter); } |