diff options
| author | Liang He <windhl@126.com> | 2022-07-19 09:54:47 +0300 |
|---|---|---|
| committer | Robert Foss <robert.foss@linaro.org> | 2022-07-19 15:48:48 +0300 |
| commit | 14e7157afb055248ed34901fcd6fbf54201cfea1 (patch) | |
| tree | 3a02c6fd8d24fdc4add5b3ae1b16bada0e3c8a21 | |
| parent | 1d43a5120ab49f22ba6c5901ad3994e254510303 (diff) | |
| download | linux-14e7157afb055248ed34901fcd6fbf54201cfea1.tar.xz | |
drm/bridge: tc358767: Add of_node_put() when breaking out of loop
In tc_probe_bridge_endpoint(), we should call of_node_put() when
breaking out of the for_each_endpoint_of_node() which will automatically
increase and decrease the refcount.
Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220719065447.1080817-2-windhl@126.com
| -rw-r--r-- | drivers/gpu/drm/bridge/tc358767.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 02bd757a8987..1dc107f13645 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2010,9 +2010,10 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc) for_each_endpoint_of_node(dev->of_node, node) { of_graph_parse_endpoint(node, &endpoint); - if (endpoint.port > 2) + if (endpoint.port > 2) { + of_node_put(node); return -EINVAL; - + } mode |= BIT(endpoint.port); } |