summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnirudh Rayabharam <mail@anirudhrb.com>2022-03-12 17:11:21 +0300
committerMichael S. Tsirkin <mst@redhat.com>2022-03-28 23:53:00 +0300
commit03a91c9af2c42ae14afafb829a4b7e6589ab5892 (patch)
tree0684f0bdb2bb2447b75d36e45729b8037c42ae49
parentb04d910af330b55e1d5d6eb9ecd53a375a9cf81c (diff)
downloadlinux-03a91c9af2c42ae14afafb829a4b7e6589ab5892.tar.xz
vhost: handle error while adding split ranges to iotlb
vhost_iotlb_add_range_ctx() handles the range [0, ULONG_MAX] by splitting it into two ranges and adding them separately. The return value of adding the first range to the iotlb is currently ignored. Check the return value and bail out in case of an error. Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> Link: https://lore.kernel.org/r/20220312141121.4981-1-mail@anirudhrb.com Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Fixes: e2ae38cf3d91 ("vhost: fix hung thread due to erroneous iotlb entries") Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
-rw-r--r--drivers/vhost/iotlb.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c
index 40b098320b2a..5829cf2d0552 100644
--- a/drivers/vhost/iotlb.c
+++ b/drivers/vhost/iotlb.c
@@ -62,8 +62,12 @@ int vhost_iotlb_add_range_ctx(struct vhost_iotlb *iotlb,
*/
if (start == 0 && last == ULONG_MAX) {
u64 mid = last / 2;
+ int err = vhost_iotlb_add_range_ctx(iotlb, start, mid, addr,
+ perm, opaque);
+
+ if (err)
+ return err;
- vhost_iotlb_add_range_ctx(iotlb, start, mid, addr, perm, opaque);
addr += mid + 1;
start = mid + 1;
}