diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-14 01:19:49 +0300 |
|---|---|---|
| committer | Hal Feng <hal.feng@starfivetech.com> | 2024-01-18 13:08:48 +0300 |
| commit | 763b81c3c09026d219b395e8147464eeecce9685 (patch) | |
| tree | 8665938da6266fe72dc7602073fcfc35f423b2fa | |
| parent | 5056faeec3eefb280125137cf82336237713a70e (diff) | |
| download | linux-763b81c3c09026d219b395e8147464eeecce9685.tar.xz | |
ASoC: starfive/jh7110-pwmdac: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231013221945.1489203-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/starfive/jh7110_pwmdac.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sound/soc/starfive/jh7110_pwmdac.c b/sound/soc/starfive/jh7110_pwmdac.c index 391544fe8568..b08f68399cfa 100644 --- a/sound/soc/starfive/jh7110_pwmdac.c +++ b/sound/soc/starfive/jh7110_pwmdac.c @@ -498,10 +498,9 @@ err_pm_disable: return ret; } -static int jh7110_pwmdac_remove(struct platform_device *pdev) +static void jh7110_pwmdac_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - return 0; } static const struct of_device_id jh7110_pwmdac_of_match[] = { @@ -517,7 +516,7 @@ static struct platform_driver jh7110_pwmdac_driver = { .pm = pm_ptr(&jh7110_pwmdac_pm_ops), }, .probe = jh7110_pwmdac_probe, - .remove = jh7110_pwmdac_remove, + .remove_new = jh7110_pwmdac_remove, }; module_platform_driver(jh7110_pwmdac_driver); |