diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-12-28 17:20:45 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-01-25 20:15:38 +0300 |
| commit | 2050d14c6ea23ea7b50b5cc7d05dbf645705cf70 (patch) | |
| tree | 01c6cadd16b86b0115c7409c676343c0c7e51665 | |
| parent | c2e5c951c2d10536a9f17647f3440e5f9f639d8b (diff) | |
| download | linux-2050d14c6ea23ea7b50b5cc7d05dbf645705cf70.tar.xz | |
[media] tuners: Refactoring for m88rs6000t_sleep()
This issue was detected by using the Coccinelle software.
1. Let us return directly if a call of the regmap_write() function failed.
2. Delete the jump label "err" then.
3. Return zero as a constant at the end.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
| -rw-r--r-- | drivers/media/tuners/m88rs6000t.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/media/tuners/m88rs6000t.c b/drivers/media/tuners/m88rs6000t.c index 504bfbc4027a..9f3e0fd4cad9 100644 --- a/drivers/media/tuners/m88rs6000t.c +++ b/drivers/media/tuners/m88rs6000t.c @@ -461,13 +461,12 @@ static int m88rs6000t_sleep(struct dvb_frontend *fe) dev_dbg(&dev->client->dev, "%s:\n", __func__); ret = regmap_write(dev->regmap, 0x07, 0x6d); - if (ret) - goto err; - usleep_range(5000, 10000); -err: - if (ret) + if (ret) { dev_dbg(&dev->client->dev, "failed=%d\n", ret); - return ret; + return ret; + } + usleep_range(5000, 10000); + return 0; } static int m88rs6000t_get_frequency(struct dvb_frontend *fe, u32 *frequency) |