summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>2020-05-28 17:50:48 +0300
committerArnd Bergmann <arnd@arndb.de>2020-05-28 17:56:56 +0300
commitb7cb430d5f11b24c1c5809ab46a098ff299b975f (patch)
treea6c6d64e287107b262bb03ed47133d77df264b2c
parent75341b3d358d27f7c22e48bcd92926c49f79e9be (diff)
downloadlinux-b7cb430d5f11b24c1c5809ab46a098ff299b975f.tar.xz
bus: bt1-apb: Use sysfs_streq instead of strncmp
There is a ready-to-use method to compare a retrieved from a sysfs node string with another string. It treats both NUL and newline-then-NUL as equivalent string terminations. So use it instead of manually truncating the line length in the strncmp() method. Link: https://lore.kernel.org/r/20200528145050.5203-4-Sergey.Semin@baikalelectronics.ru Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Olof Johansson <olof@lixom.net> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: soc@kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/bus/bt1-apb.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index 7e57fc2af745..b25ff941e7c7 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -325,9 +325,9 @@ static ssize_t inject_error_store(struct device *dev,
* Either dummy read from the unmapped address in the APB IO area
* or manually set the IRQ status.
*/
- if (!strncmp(data, "nodev", 5))
+ if (sysfs_streq(data, "nodev"))
readl(apb->res);
- else if (!strncmp(data, "irq", 3))
+ else if (sysfs_streq(data, "irq"))
regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
APB_EHB_ISR_PENDING);
else