diff options
| author | Sabrina Dubroca <sd@queasysnail.net> | 2020-04-22 18:29:51 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-04-23 22:39:09 +0300 |
| commit | 9a7b5b50de8a764671ba1800fe4c52d3b7013901 (patch) | |
| tree | a0a5aea9ca7101e1159e54f63b851b7d4985e1f3 | |
| parent | cc8e7c69db4dcc565ed3020f97ddd6debab6cbe8 (diff) | |
| download | linux-9a7b5b50de8a764671ba1800fe4c52d3b7013901.tar.xz | |
geneve: use the correct nlattr array in NL_SET_ERR_MSG_ATTR
IFLA_GENEVE_* attributes are in the data array, which is correctly
used when fetching the value, but not when setting the extended
ack. Because IFLA_GENEVE_MAX < IFLA_MAX, we avoid out of bounds
array accesses, but we don't provide a pointer to the invalid
attribute to userspace.
Fixes: a025fb5f49ad ("geneve: Allow configuration of DF behaviour")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/geneve.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 09f279c0182b..6b461be1820b 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -1207,7 +1207,7 @@ static int geneve_validate(struct nlattr *tb[], struct nlattr *data[], enum ifla_geneve_df df = nla_get_u8(data[IFLA_GENEVE_DF]); if (df < 0 || df > GENEVE_DF_MAX) { - NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_GENEVE_DF], + NL_SET_ERR_MSG_ATTR(extack, data[IFLA_GENEVE_DF], "Invalid DF attribute"); return -EINVAL; } |