diff options
| author | Wan Jiabing <wanjiabing@vivo.com> | 2022-03-07 12:41:48 +0300 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2022-03-22 20:51:17 +0300 |
| commit | 05e815539f3f161585c13a9ab023341bade2c52f (patch) | |
| tree | a7e4119704ac9252cdab35bc345bf1f40193c18f | |
| parent | 74be98774dfbc5b8b795db726bd772e735d2edd4 (diff) | |
| download | linux-05e815539f3f161585c13a9ab023341bade2c52f.tar.xz | |
cxl/core/port: Fix NULL but dereferenced coccicheck error
Fix the following coccicheck warning:
./drivers/cxl/core/port.c:913:21-24: ERROR: port is NULL but dereferenced.
The put_device() is only relevent in the is_cxl_root() case.
Fixes: 2703c16c75ae ("cxl/core/port: Add switch port enumeration")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20220307094158.404882-1-wanjiabing@vivo.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | drivers/cxl/core/port.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index c1681248f322..2ab1ba4499b3 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -911,7 +911,10 @@ static void cxl_detach_ep(void *data) break; port = find_cxl_port(dport_dev); - if (!port || is_cxl_root(port)) { + if (!port) + continue; + + if (is_cxl_root(port)) { put_device(&port->dev); continue; } |