diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-04-22 01:42:22 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-04-25 13:46:24 +0300 |
commit | 7c762e70c50b462fabe44a597e2a6c3e56c236c0 (patch) | |
tree | 8eeb1e55e74181cb02c3daf886415ffd9a833df5 /.cocciconfig | |
parent | 31c417c948d7f6909cb63f0ac3298f3c38f8ce20 (diff) | |
download | linux-7c762e70c50b462fabe44a597e2a6c3e56c236c0.tar.xz |
net: dsa: flood multicast to CPU when slave has IFF_PROMISC
Certain DSA switches can eliminate flooding to the CPU when none of the
ports have the IFF_ALLMULTI or IFF_PROMISC flags set. This is done by
synthesizing a call to dsa_port_bridge_flags() for the CPU port, a call
which normally comes from the bridge driver via switchdev.
The bridge port flags and IFF_PROMISC|IFF_ALLMULTI have slightly
different semantics, and due to inattention/lack of proper testing, the
IFF_PROMISC flag allows unknown unicast to be flooded to the CPU, but
not unknown multicast.
This must be fixed by setting both BR_FLOOD (unicast) and BR_MCAST_FLOOD
in the synthesized dsa_port_bridge_flags() call, since IFF_PROMISC means
that packets should not be filtered regardless of their MAC DA.
Fixes: 7569459a52c9 ("net: dsa: manage flooding on the CPU ports")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions