From 5bd355ee3b0191c6846918b049b3940182bec1cb Mon Sep 17 00:00:00 2001 From: Tomas Henzl Date: Wed, 30 Jul 2014 16:40:51 +0200 Subject: pm8001: Fix erratic calculation in update_flash The loopcount is calculated by using some weird magic. Use instead a boring macro. Signed-off-by: Tomas Henzl Acked-by: Suresh Thiagarajan Signed-off-by: Christoph Hellwig --- drivers/scsi/pm8001/pm8001_ctl.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'drivers/scsi/pm8001') diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index d3a08aea0948..e9b0921e9450 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -581,11 +581,8 @@ static int pm8001_update_flash(struct pm8001_hba_info *pm8001_ha) partitionSizeTmp = *(u32 *)((u8 *)&image_hdr->image_length + sizeRead); partitionSize = be32_to_cpu(partitionSizeTmp); - loopcount = (partitionSize + HEADER_LEN)/IOCTL_BUF_SIZE; - if (loopcount % IOCTL_BUF_SIZE) - loopcount++; - if (loopcount == 0) - loopcount++; + loopcount = DIV_ROUND_UP(partitionSize + HEADER_LEN, + IOCTL_BUF_SIZE); for (loopNumber = 0; loopNumber < loopcount; loopNumber++) { payload = (struct pm8001_ioctl_payload *)ioctlbuffer; payload->length = 1024*16; -- cgit v1.2.3