From b9b8218bb3c064628799f83c754dbebd124bd498 Mon Sep 17 00:00:00 2001 From: Dongliang Mu Date: Sun, 17 Oct 2021 20:50:21 +0800 Subject: can: xilinx_can: xcan_remove(): remove redundant netif_napi_del() Since netif_napi_del() is already done in the free_candev(), we remove this redundant netif_napi_del() invocation. In addition, this patch can match the operations in the xcan_probe() and xcan_remove() functions. Link: https://lore.kernel.org/all/20211017125022.3100329-1-mudongliangabcd@gmail.com Signed-off-by: Dongliang Mu Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'drivers/net/can/xilinx_can.c') diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 85c2ed5df4c7..e2b15d29d15e 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1843,11 +1843,9 @@ err: static int xcan_remove(struct platform_device *pdev) { struct net_device *ndev = platform_get_drvdata(pdev); - struct xcan_priv *priv = netdev_priv(ndev); unregister_candev(ndev); pm_runtime_disable(&pdev->dev); - netif_napi_del(&priv->napi); free_candev(ndev); return 0; -- cgit v1.2.3