From 10c8204c8b172234f11a0482a89fb4affadfaab5 Mon Sep 17 00:00:00 2001 From: Douglas Anderson Date: Fri, 1 Sep 2023 16:39:55 -0700 Subject: drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at remove time. Let's add it. The fact that we should call drm_atomic_helper_shutdown() in the case of OS driver remove comes straight out of the kernel doc "driver instance overview" in drm_drv.c. Suggested-by: Maxime Ripard Acked-by: Maxime Ripard Signed-off-by: Douglas Anderson Link: https://patchwork.freedesktop.org/patch/msgid/20230901163944.RFT.4.I4752a39ad9f8fd08b32c2b78a8a3e40491bfb5eb@changeid --- drivers/gpu/drm/solomon/ssd130x.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/gpu/drm/solomon') diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 8ab02724f65f..531e080e6ffb 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1245,6 +1245,7 @@ EXPORT_SYMBOL_GPL(ssd130x_probe); void ssd130x_remove(struct ssd130x_device *ssd130x) { drm_dev_unplug(&ssd130x->drm); + drm_atomic_helper_shutdown(&ssd130x->drm); } EXPORT_SYMBOL_GPL(ssd130x_remove); -- cgit v1.2.3