From aa1221b2584f06066d1e6b22ef7950fb12d94864 Mon Sep 17 00:00:00 2001 From: Benjamin Herrenschmidt Date: Mon, 6 Aug 2018 12:22:37 +1000 Subject: fsi: scom: Fix NULL dereference The chardev conversion forgot to copy the fsi_dev, silly mistake, compounded by a testing mistake on my side, this specific driver wasn't being tested properly. Fixes: d8f4587655f9 "fsi: scom: Convert to use the new chardev" Signed-off-by: Benjamin Herrenschmidt --- drivers/fsi/fsi-scom.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/fsi/fsi-scom.c') diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 0f303a700f69..df94021dd9d1 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -598,6 +598,7 @@ static int scom_probe(struct device *dev) kfree(scom); return -ENODEV; } + scom->fsi_dev = fsi_dev; /* Create chardev for userspace access */ scom->dev.type = &fsi_cdev_type; -- cgit v1.2.3