From 038903593317691cf5f87ba1286627f5e8ab5660 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 22 Feb 2019 22:55:30 +0300 Subject: ipmi_si: Potential array underflow in hotmod_handler() The "ival" variable needs to signed so that we don't read before the start of the str[] array. This would only happen the user passed in a module parameter that was just comprised of space characters. Fixes: e80444ae4fc3 ("ipmi_si: Switch hotmod to use a platform device") Signed-off-by: Dan Carpenter Message-Id: <20190222195530.GA306@kadam> Signed-off-by: Corey Minyard --- drivers/char/ipmi/ipmi_si_hotmod.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers/char') diff --git a/drivers/char/ipmi/ipmi_si_hotmod.c b/drivers/char/ipmi/ipmi_si_hotmod.c index 1433055a9705..03140f6cdf6f 100644 --- a/drivers/char/ipmi/ipmi_si_hotmod.c +++ b/drivers/char/ipmi/ipmi_si_hotmod.c @@ -187,7 +187,8 @@ static int hotmod_handler(const char *val, const struct kernel_param *kp) char *str = kstrdup(val, GFP_KERNEL), *curr, *next; int rv; struct ipmi_plat_data h; - unsigned int len, ival; + unsigned int len; + int ival; if (!str) return -ENOMEM; -- cgit v1.2.3