summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-06-27staging: bcm: nvm.c: Cleaning up check unsigned is less than zeroRickard Strandqvist1-2/+2
Remove checking if a unsigned int is less than zero This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: hostmibs.c: Shortened linesMatthias Beyer1-13/+26
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: replaced member accessing with variable for readabilityMatthias Beyer1-11/+12
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Added missing blank line after declarationsMatthias Beyer1-0/+1
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Replaced member accssing with variableMatthias Beyer1-8/+10
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Whitespace for indentation fixedMatthias Beyer1-1/+1
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: line length fixedMatthias Beyer1-1/+2
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Line length cleanupMatthias Beyer1-6/+19
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Shortened some lines in ↵Matthias Beyer1-29/+18
select_alternate_setting_for_highspeed_modem() Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Outsourced selecting of alternate settingMatthias Beyer1-95/+112
This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Merged some lines which got shorter by the latest patchMatthias Beyer1-26/+17
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()Matthias Beyer1-26/+27
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Replaced member accessing with variable in device_run()Matthias Beyer1-11/+9
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: replaced member accessing by variableMatthias Beyer1-9/+9
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: Shortened some linesMatthias Beyer1-2/+4
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced nested ifs with logical AND concatenationMatthias Beyer1-9/+8
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced member accessing by variableMatthias Beyer1-6/+8
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced member accessing by variableMatthias Beyer1-12/+13
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced doubled if-check by logical OR in one ↵Matthias Beyer1-7/+4
check Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced time selecting ifelse with ternary ↵Matthias Beyer1-4/+2
operator Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: More variable names refactoredMatthias Beyer1-14/+14
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Refactored line lengthsMatthias Beyer1-18/+10
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Removed dead codeMatthias Beyer1-61/+37
This patch removes the never-entered else-block inside blink_in_normal_bandwidth(). The condition of the preceding if statement is always true. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Refactored variable nameMatthias Beyer1-7/+7
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Outsourced code chunkMatthias Beyer1-66/+93
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Replaced member accessingMatthias Beyer1-11/+9
This patch replaces member accessing with a variable in BcmGetGPIOPinInfo(). Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Simplified nested if conditionsMatthias Beyer1-21/+19
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.{c,h}: Fixed macroMatthias Beyer2-24/+31
This patch fixes the TURN_{ON,OFF}_LED() macros by adding the adapter as parameter. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Outsourced adapter driver state handlingMatthias Beyer1-154/+171
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: bcm: led_control.c: Indentation/Whitespace/Line length cleanupMatthias Beyer1-59/+79
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27Staging: slicoss: fixed frivolous else statement warnings in slicoss.cVincent Heuken1-10/+12
This is a patch for the slicoss.c file that fixes four instances of the following warning: WARNING: else is not generally useful after a break or return Signed-off-by: Vincent Heuken <me@vincentheuken.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: emxx_udc: Use module_platform_driverSachin Kamat1-18/+1
module_platform_driver removes some boiler plate and makes code simpler. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: emxx_udc: Fix build errorSachin Kamat1-4/+3
devm_request_and_ioremap has been removed since commit c9d53c0f2d23 ("devres: remove devm_request_and_ioremap()") Use devm_ioremap_resource instead. While at it, also remove redundant error message as it is now handled by devm_ioremap_resource. Without this patch we get the following build error: drivers/staging/emxx_udc/emxx_udc.c:3370:2: error: implicit declaration of function ‘devm_request_and_ioremap’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: lustre: llite: dir.c - fix for coding style issuesAnil Belur1-2/+2
- this fixes some coding style issues "ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: lustre: llite: dir.c - fixes indented labels in codeAnil Belur1-8/+8
- this fixes "WARNING: labels should not be indented" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: lustre: llite: llite_capa.c - fixed warning to use recomended ↵Anil Belur1-1/+1
headers <linux/uaccess.h> - this fixes "WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: lustre: llite: llite_capa.c - fixes checkpatch errors - unecessary ↵Anil Belur1-4/+4
init of static variables to 0 - this commit fixes some "ERROR: do not initialise statics to 0 or NULL" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging: lustre: lustre: libcfs: fail.c - fix sparse warnings EXPORT_SYMBOLAnil Belur1-4/+6
- this fixes "WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/lnet: abort messages whose MD has been unlinkedIsaac Huang4-26/+45
If LNetMDUnlink has been called, all outgoing messages on that MD should be aborted before lnet_ni_send() is called. Signed-off-by: Isaac Huang <he.huang@intel.com> Reviewed-on: http://review.whamcloud.com/8041 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4006 Reviewed-by: Liang Zhen <liang.zhen@intel.com> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/llite: fix a flag bug of vvp_io_kernel_fault()Li Xi1-1/+1
After vvp_io_kernel_fault() locked the page, it should set VM_FAULT_LOCKED. Signed-off-by: Li Xi <lixi@ddn.com> Reviewed-on: http://review.whamcloud.com/10740 Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-by: Emoly Liu <emoly.liu@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/vvp: release mmap_sem in error casePatrick Farrell1-1/+3
The mmap_sem is downed in vvp_mmap_locks, but in case of error from cl_io_lock_alloc_add, it is not upped. Credit to Paul Casella at Cray for finding this. Signed-off-by: Patrick Farrell <paf@cray.com> Reviewed-on: http://review.whamcloud.com/10741 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5221 Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/obdclass: runtime load lustre client when neededBob Glossman1-1/+4
Manually force loading of lustre.ko during client mounts with request_module for cases where autoloading doesn't happen. Signed-off-by: Bob Glossman <bob.glossman@intel.com> Reviewed-on: http://review.whamcloud.com/10587 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4800 Reviewed-by: John L. Hammond <john.hammond@intel.com> Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: Yang Sheng <yang.sheng@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/ptlrpc: unlink request buffer correctlyAlexey Lyashkov4-13/+18
outgoning buffer may be hold by lnet and don't unlinked fast, it's break unloading a lustre modules as request hold a reference to the export/obd Signed-off-by: Alexey Lyashkov <alexey_lyashkov@xyratex.com> Xyratex-bug-id: MRP-1848 Reviewed-on: http://review.whamcloud.com/10353 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5073 Reviewed-by: Mike Pershin <mike.pershin@intel.com> Reviewed-by: Liang Zhen <liang.zhen@intel.com> Reviewed-by: Isaac Huang <he.huang@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/llite: Fix uninitialized variableDmitry Eremin1-0/+1
'f.f_flags' might be used uninitialized in this function. xattr.c:248: 'f.f_flags' is declared. xattr.c:244: lump!= ( (void* )0) is true xattr.c:254: 'f.f_flags' is used, but is uninitialized. Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-on: http://review.whamcloud.com/10663 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: James Simmons <uja.ornl@gmail.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/osc: osc_extent_truncate()) ASSERTION( !ext->oe_urgent ) failedAndriy Skulysh1-3/+4
The bug was caused by race between truncate & fsync. osc_extent_wait() doesn't takes into account oe_trunc_pending during setting oe_urgent. The race arises after osc_object_unlock(). osc_extent_wait() should ignore extents with oe_trunc_pending while waiting for OES_INV. osc_cache_truncate_end() will set oe_urgent and call osc_io_unplug_async() Signed-off-by: Andriy Skulysh <Andriy_Skulysh@xyratex.com> Reviewed-on: http://review.whamcloud.com/10204 Xyratex-bug-id: LELUS-239 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4852 Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/obdclass: Fix uninitialized variablesDmitry Eremin1-0/+5
'sd.page_link' is used uninitialized in this function. 'ss.page_link' is used uninitialized in this function. 'sl.page_link' is used uninitialized in this function. Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-on: http://review.whamcloud.com/10613 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: John L. Hammond <john.hammond@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/ptlrpc: Add schedule point to ptlrpc_check_set()Christopher J. Morrone1-0/+10
Most ptlrpc sets are believed to be small and bounded in length. However at the very least the ptlrpcd reuses the ptlrpc sets at its primary work queue. This work queue can easily have work added faster than the ptlrpcd thread can process the work. The unbounded work can lead to the ptlrpcd monopolizing a CPU for hundreds of seconds. Obviously a well-behaved kernel function should obey the scheduler and share the processor. We address that problem by inserting a cond_resched() at the top of the main loop of ptlrpc_check_set(). Some have suggested putting the cond_resched() lower in the loop. However, the only current way to bound the number of loops that we exceed our allocated run time is to put the call at the top of the loop. Putting it lower would allow an unknown number (and since it is unknown, it might be excessively large at times) of cycles through the loop before a resched is allowed. Signed-off-by: Christopher J. Morrone <morrone2@llnl.gov> Reviewed-on: http://review.whamcloud.com/10358 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5053 Reviewed-by: Liang Zhen <liang.zhen@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/mgc: replace hard-coded MGC_ENQUEUE_LIMIT valueCheng Shao1-1/+4
During client mount, the client will send an LDLM_ENQUEUE request to MGS with send delay set to MGC_ENQUEUE_LIMIT, which is hard coded to 50 seconds. On the other hand, the interval for pinger is deduced from obd_timeout. When obd_timeout is configured for a longer period of time, so does the pinger. We know that connecting to the secondary MGS node is triggered by the pinger. Now that we have a longer interval, the pinger will not be able to try the secondary before the LDLM_ENQUEUE request fails the mount using the same delay limit. This code change will replace the hard-coded send delay being mentioned above with a value that is long enough to give the client a chance to connect to the secondary MGS if exists. Signed-off-by: Cheng Shao <cheng_shao@xyratex.com> Reviewed-on: http://review.whamcloud.com/9217 Xyratex-bug-id: MRP-1516 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4582 Reviewed-by: Ryan Haasken <haasken@cray.com> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/ptlrpc: race at req processingAlexander.Boyko3-1/+14
Race between ptlrpc_resend_req() and ptlrpc_check_set(). 1 thread do ptlrpc_check_set()->after_reply() 2 thread do ptlrpc_resend_req() The result is request with rq_resend = 1 and MSG_REPLY flag. When this request will came to server it will cause client eviction. The patch skip ptlrpc_resend_req logic if rq_replied is set, and clear rq_resend flag at reply_in_callback() when client got reply. Signed-off-by: Alexander Boyko <alexander_boyko@xyratex.com> Xyratex-bug-id: MRP-1888 Reviewed-on: http://review.whamcloud.com/10471 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5116 Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Mike Pershin <mike.pershin@intel.com> Reviewed-by: Chris Horn <hornc@cray.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-27staging/lustre/osc: get rid of old checksum initial valueBobi Jam1-6/+1
Old code residue assumes initial checksum value as ~0, and relies on that to check whether OST server has calculated bulk data checksum. That is not the case anymore. Signed-off-by: Bobi Jam <bobijam.xu@intel.com> Reviewed-on: http://review.whamcloud.com/10354 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4937 Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.0) at 2026-02-27 22:41:31 +0300