summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-05-17staging: dgap: refactor ugly dgap_init_one functionMark Hounschell1-11/+8
This patch just cleans up the ugly dgap_init_one function Signed-off-by: Mark Hounschell <markh@compro.net> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-17staging: rtl8723au: Do not reset wdev->iftype in netdev_close()Jes Sorensen1-2/+0
wdev->ifdev should be set by .change_virtual_intf(). This solves the problem of WARN() messages on module unload. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: Add check for MAXBOARDS in .probe (dgap_init_one)Mark Hounschell1-0/+3
Insure we don't allow configuring more than MAXBOARDS (32). Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: remove two unnecessary conditionalsMark Hounschell1-18/+14
Remove 2 unnessessary conditionals. They are always false in this code path. Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: check unchecked return valuesMark Hounschell1-2/+7
Check the return values of dgap_tty_register and dgap_finalize_board_init. If they fail for a particular board we should not be able to try to use that board. IE. no device entries shall be created for that board. Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix a few more sparse warningsMark Hounschell1-18/+19
This patch fixes a few more sparse warnings related to __iomem version 2 excludes a change that actually caused a new sparse warning. Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix sparse warnings Using plain integer as NULL pointerMark Hounschell1-16/+16
This patch fixes sparse warnings: warning: Using plain integer as NULL pointer Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix sparse warning about dgap_poll_lockMark Hounschell1-1/+1
This patch fixes a sparse warning: warning: symbol 'dgap_poll_lock' was not declared. Should it be static? Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix a few misc sparse warningsMark Hounschell2-13/+13
This patch fixes a few misc sparse warnings related to __iomem Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix sparse warnings for the entire cm_t structureMark Hounschell2-5/+5
This patch fixes sparse warnings for the entire cm_t structure This entire structure defines a hardware segment Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix sparse warnings for the entire bs_t structureMark Hounschell2-13/+13
This patch fixes sparse warnings for the entire bs_t structure This entire structure defines a hardware segment Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: fix sparse warnings for re_map_membase and re_map_portMark Hounschell2-14/+14
This patch fixes sparse warnings for the re_map_membase and re_map_port variables. Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: Fix BUG in processing config fileMark Hounschell1-1/+9
This patch fixes an OOPS caused by a pointer being changed between the malloc and free. Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Reported-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: Fix how we insure config data is a stringMark Hounschell1-2/+1
This patch changes the way we insure the config data is a string. Clearly this was just wrong. After a certain number of loads/unloads various OOPs were generated indicating something other than this driver had a problem. It was this driver. Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Reported-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: dgap: Add Mark Hounschell to maintainers list for dgapMark Hounschell1-0/+1
Add Mark Hounschell to the MAINTAINERs list for the dgap driver Signed-off-by: Mark Hounschell <markh@compro.net> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Remove task from TODO listMichalis Pappas1-1/+0
Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function kernel_thread') Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Indentation and other whitespace fixesMichalis Pappas10-129/+97
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Whitespace fixes to conform to coding standardsMichalis Pappas8-123/+101
Fixes the following checkpatch.pl issues: WARNING: unnecessary whitespace before a quoted newline CHECK: Alignment should match open parenthesis CHECK: No space is necessary after a cast Also some additional, whitespace related, readability issues. Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Removed commented-out codeMichalis Pappas4-43/+1
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Fix braces to conform with coding styleMichalis Pappas2-11/+12
Fixes the following checkpatch.pl issue: CHECK: braces {} should be used on all arms of this statement Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Fix some camel-case variablesMichalis Pappas1-16/+15
Fixes the following checkpatch.pl issue: CHECK: Avoid CamelCase: Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Move logical continuation to previous line to conform to ↵Michalis Pappas1-2/+2
coding style Fixes the following checkpatch.pl issue: CHECK: Logical continuations should be on the previous line Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Modify a struct allocation to match coding standardsMichalis Pappas1-1/+1
Fixes the following checkpatch.pl issue: CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct qos_entry_s)...) Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Replace comparisons on jiffies values with wrap-safe functionsMichalis Pappas2-3/+3
Fixes the following checkpatch.pl issue: WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: gdm72xx: Remove unnecessary extern declarations from header filesMichalis Pappas3-6/+6
Fixes the following checkpatch.pl issue: CHECK: extern prototypes should be avoided in .h files Signed-off-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Remove some unused ODM dynamic TX power functionalityJes Sorensen2-80/+4
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: The DBG_IO code is all goneJes Sorensen1-6/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Remove some leftover obsolete prototypesJes Sorensen1-7/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Name port vs register access functions consistentlyJes Sorensen6-27/+27
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call usb_write*() functions directlyJes Sorensen23-568/+476
This allows us to finally remove the ugly HAL interface for accessing registers, and remove rtw_io.c Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call usb_read*() functions directlyJes Sorensen20-235/+209
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layerJes Sorensen4-9/+3
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call usb_{read,write}_port() functions directlyJes Sorensen7-45/+6
Get rid of more HAL layer obfuscations Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Clean up usb_{read,write}_port() usageJes Sorensen8-82/+23
Get rid of silly HAL convolution for calling usb_{read,write}_port() functions. Benefit from fact we just have one input address for read_port, so no point storing this and carrying it around. Pick pipe in the local function instead of based on dst/src address. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Use correct pipe type for USB interruptsJes Sorensen1-1/+1
Use a correct pipe type when filling un interrupt urbs. This should finally take care of the WARN() messages on the console when USB urbs are submitted. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Clean up mess of parenthesis abuseJes Sorensen1-39/+49
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: usb_ops_linux.h: Remove some unused #definesJes Sorensen1-3/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Remove nasty wrappers used to hide wrong function typesJes Sorensen3-10/+3
Do not use #defines to hack around pre-history functions not matching current APIs Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Remove unused USB bulk related macros and variablesJes Sorensen3-35/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Don't wrap calls to usb_control_msg()Jes Sorensen2-7/+3
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call usb_intf_{start,stop} directlyJes Sorensen5-24/+9
Rip out multiple layer of useless wrappers Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Call rtl8723au_set_hw_type() directlyJes Sorensen2-10/+1
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Remove unused usb_suspend_semaJes Sorensen2-3/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: Move last utility function from osdep_service.c to ↵Jes Sorensen2-1/+6
os_intfs.c No point carrying a dedicated file just for this small helper, so move it to os_intfs.c and get rid of osdep_service.c Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: os_intfs.c: Various cosmetic cleanupsJes Sorensen2-60/+38
In addition skb->priorty is a u32, so make rtw_classify8021d return a u32 to match. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: os_dep/usb_ops_linux.c: More bad parenthesis cleanupJes Sorensen1-19/+26
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: hal/usb_ops_linux.c: Various cleanupsJes Sorensen1-49/+57
Reduce excessive parenthesis usage, remove unnecessary null initialization of variables, and some bad formatting. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: odm_precomp.h: Remove unused #define TEST_FALG__Jes Sorensen1-2/+0
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: hal_com.c: Fix one case of returning status in an s32Jes Sorensen1-2/+2
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rtl8723au: rtl8723a_cmd.c: Fix up bad return typesJes Sorensen2-13/+13
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>