summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-08-10btrfs: remove junk sb_dirt changeArtem Bityutskiy1-1/+0
BTRFS does not define a '->write_super()' method, so it should not mark its superblock as dirty. This looks like some left-over. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Acked-by: Chris Mason <chris.mason@oracle.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10BFS: clean up the superblock usageArtem Bityutskiy3-43/+7
BFS is a very simple FS and its superblocks contains only static information and is never changed. However, the BFS code for some misterious reasons marked its buffer head as dirty from time to time, but nothing in that buffer was ever changed. This patch removes all the BFS superblock manipulation, simply because it is not needed. It removes: 1. The si_sbh filed from 'struct bfs_sb_info' because it is not needed. We only need to read the SB once on mount to get the start of data blocks and the FS size. After this, we can forget about the SB. 2. All instances of 'mark_buffer_dirty(sbh)' for BFS SB because it is never changed. 3. The '->sync_fs()' method because there is nothing to sync (inodes are synched by VFS). 4. The '->write_super()' method, again, because the SB is never changed. Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10AFFS: wait for sb synchronization when neededArtem Bityutskiy1-5/+7
AFFS does not ever wait for superblock synchronization in ->put_super(), ->write_super, and ->sync_fs(). However, it should wait for synchronization in ->put_super() because it is about to be unmounted, in ->write_super() because this is periodic SB synchronization performed from a separate kernel thread, and in ->sync_fs() it should respect the 'wait' flag. This patch fixes the situation. Also, in ->put_super(), do not write the SB if it is not dirty. Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10AFFS: clean up dirty flag usageArtem Bityutskiy1-14/+5
In 'affs_write_super()': remove ancient and wrong commented code, remove unneeded 'clean' variable, so the function becomes a bit cleaner and simpler. In 'affs_remount(): remove unnecessary SB dirty flag changes. Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10cifs: truncate falloutChristoph Hellwig1-23/+7
Remove the calls to inode_newsize_ok given that we already did it as part of inode_change_ok in the beginning of cifs_setattr_(no)unix. No need to call ->truncate if cifs doesn't have one, so remove the explicit call in cifs_vmtruncate, and replace the calls to vmtruncate with truncate_setsize which is vmtruncate minus inode_newsize_ok and the call to ->truncate. Rename cifs_vmtruncate to cifs_setsize to match the new calling conventions. Question 1: why does cifs do the pagecache munging and i_size update twice for each setattr call, once opencoded in cifs_vmtruncate, and once using the VFS helpers? Question 2: what is supposed to be protected by i_lock in cifs_vmtruncate? Do we need it around the call to inode_change_ok? [AV: fixed build breakage] Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10mbcache: fix shrinker function return valueAndreas Gruenbacher1-17/+10
The shrinker function is supposed to return the number of cache entries after shrinking, not before shrinking. Fix that. Based on a patch from Wang Sheng-Hui <crosslonelyover@gmail.com>. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10mbcache: Remove unused featuresAndreas Gruenbacher5-137/+60
The mbcache code was written to support a variable number of indexes, but all the existing users use exactly one index. Simplify to code to support only that case. There are also no users of the cache entry free operation, and none of the users keep extra data in cache entries. Remove those features as well. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10add f_flags to struct statfs(64)Christoph Hellwig5-13/+89
Add a flags field to help glibc implementing statvfs(3) efficiently. We copy the flag values from glibc, and add a new ST_VALID flag to denote that f_flags is implemented. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10pass a struct path to vfs_statfsChristoph Hellwig11-46/+67
We'll need the path to implement the flags field for statvfs support. We do have it available in all callers except: - ecryptfs_statfs. This one doesn't actually need vfs_statfs but just needs to do a caller to the lower filesystem statfs method. - sys_ustat. Add a non-exported statfs_by_dentry helper for it which doesn't won't be able to fill out the flags field later on. In addition rename the helpers for statfs vs fstatfs to do_*statfs instead of the misleading vfs prefix. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10update VFS documentation for method changes.Al Viro2-10/+39
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10All filesystems that need invalidate_inode_buffers() are doing that explicitlyAl Viro1-1/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert remaining ->clear_inode() to ->evict_inode()Al Viro34-59/+94
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10Make ->drop_inode() just return whether inode needs to be droppedAl Viro10-103/+60
... and let iput_final() do the actual eviction or retention Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10fs/inode.c:clear_inode() is goneAl Viro2-25/+4
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10fs/inode.c:evict() doesn't care about delete vs. non-delete paths nowAl Viro1-4/+4
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10->delete_inode() is goneAl Viro2-3/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert ext4 to ->evict_inode()Al Viro4-10/+16
pretty much brute-force... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert logfs to ->evict_inode()Al Viro3-36/+31
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10logfs: get rid of magical inodesAl Viro6-41/+31
ordering problems at ->kill_sb() time are solved by doing iput() of these suckers in ->put_super() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert nilfs2 to ->evict_inode()Al Viro3-24/+26
[folded build fix from sfr] Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert exofs to ->evict_inode()Al Viro3-6/+6
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert reiserfs to ->evict_inode()Al Viro3-11/+12
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert btrfs to ->evict_inode()Al Viro3-4/+8
NB: do we want btrfs_wait_ordered_range() on eviction of inodes with positive i_nlink on subvolume with zero root_refs? If not, btrfs_evict_inode() can be simplified by unconditionally bailing out in case of i_nlink > 0 in the very beginning... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch gfs2 to ->evict_inode()Al Viro1-24/+15
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert ocfs2 to ->evict_inode()Al Viro3-11/+16
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch ncpfs to ->evict_inode()Al Viro1-6/+6
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch udf to ->evict_inode()Al Viro4-35/+21
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch ubifs to ->evict_inode()Al Viro1-4/+8
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch jfs to ->evict_inode()Al Viro3-25/+20
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch hpfs to ->evict_inode()Al Viro3-7/+9
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch hppfs to ->evict_inode()Al Viro1-4/+3
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10try to get rid of races in hostfs open()Al Viro3-12/+37
In case of mode mismatch, do *not* blindly close the descriptor another openers might be using right now. Open the underlying file with currently sufficient mode, then * if current mode has grown so that it's sufficient for us now, just close our new fd * if current mode has grown and our fd is *not* enough to cover it, close and repeat. * otherwise, install our fd if the file hadn't been opened at all or dup2() our fd over the current one (and close our fd). Critical section is protected by mutex; yes, system-wide. All we do under it is a bunch of comparison and maybe an overwriting dup2() on host. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10leak in hostfs_unlink()Al Viro1-2/+3
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: fix races in dentry_name() and inode_name()Al Viro1-46/+60
calculating size, then doing allocation, then filling the path is a Bad Idea(tm), since the ancestors can be renamed, leading to buffer overrun. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10new helper: __dentry_path()Al Viro2-5/+23
builds path relative to fs root, called under dcache_lock, doesn't append any nonsense to unlinked ones. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: sanitize symlinksAl Viro1-26/+35
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: get rid of inode_dentry_name()Al Viro1-35/+20
it's equivalent to dentry_name() anyway Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: get rid of file_type(), fold init_inode()Al Viro3-93/+45
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch stat_file() to passing a single struct rather than fsckloads of pointersAl Viro3-68/+58
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: pass pathname to init_inode()Al Viro1-30/+15
We will calculate it in all callers anyway, so there's no need to duplicate that inside. Moreover, that way we lose all failure exits in init_inode(), so it doesn't need to return anything. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10get rid of hostfs_read_inode()Al Viro1-53/+16
There are only two call sites; in one (hostfs_iget()) it's actually a no-op and in another (fill_super()) it's easier to expand the damn thing and use what we know about its arguments to simplify it. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10hostfs: don't keep a field in each inode when we are using it only in rootAl Viro1-24/+15
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10stop icache pollution in hostfs, switch to ->evict_inode()Al Viro1-22/+8
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch affs to ->evict_inode()Al Viro3-17/+14
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch omfs to ->evict_inode()Al Viro1-3/+6
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch bfs to ->evict_inode(), clean upAl Viro1-38/+32
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10convert ext3 to ->evict_inode()Al Viro4-36/+29
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10spufs conversion to ->evict_inode()Al Viro1-5/+3
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10switch ufs to ->evict_inode()Al Viro4-21/+28
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-10covert fatfs to ->evict_inode()Al Viro1-11/+9
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>