diff options
| author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2014-02-07 00:04:28 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-02-07 01:48:51 +0400 |
| commit | 227d53b397a32a7614667b3ecaf1d89902fb6c12 (patch) | |
| tree | cfdccad47eb1404da7a657cd260af3ba1b3c3120 /virt | |
| parent | 7bc35fdde6724549a0239b71e08b9f33d8bf2bfb (diff) | |
| download | linux-227d53b397a32a7614667b3ecaf1d89902fb6c12.tar.xz | |
mm: __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq
To use spin_{un}lock_irq is dangerous if caller disabled interrupt.
During aio buffer migration, we have a possibility to see the following
call stack.
aio_migratepage [disable interrupt]
migrate_page_copy
clear_page_dirty_for_io
set_page_dirty
__set_page_dirty_buffers
__set_page_dirty
spin_lock_irq
This mean, current aio migration is a deadlockable. spin_lock_irqsave
is a safer alternative and we should use it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reported-by: David Rientjes rientjes@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions