diff options
author | Julia Lawall <julia@diku.dk> | 2010-09-05 13:00:22 +0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-10-13 09:19:04 +0400 |
commit | 8032214346c0c892e859cf6eee6c8ba305cbfe78 (patch) | |
tree | 77438b235db10a3a6fc9030e01c82759cc461984 /tools | |
parent | a655237fa2f9e4afe9949abe2c511432ab9537dd (diff) | |
download | linux-8032214346c0c892e859cf6eee6c8ba305cbfe78.tar.xz |
i2c/i2c-pasemi.c: Fix unsigned return type
The function has an unsigned return type, but returns a negative constant
to indicate an error condition. The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.
A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@exists@
identifier f;
constant C;
@@
unsigned f(...)
{ <+...
* return -C;
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions