diff options
| author | Alan Mikhak <alan.mikhak@sifive.com> | 2019-05-24 00:18:00 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-24 10:23:34 +0300 |
| commit | d09d148cad42abf45addbf6f1d39733e2993d899 (patch) | |
| tree | e2f5d9645e3069d03c526e60611a07443d9ca779 /tools | |
| parent | 1dee3a3efdb877419639f3cafb1f91cfcf9c11ab (diff) | |
| download | linux-d09d148cad42abf45addbf6f1d39733e2993d899.tar.xz | |
tools: PCI: Fix broken pcitest compilation
[ Upstream commit 8a5e0af240e07dd3d4897eb8ff52aab757da7fab ]
pcitest is currently broken due to the following compiler error
and related warning. Fix by changing the run_test() function
signature to return an integer result.
pcitest.c: In function run_test:
pcitest.c:143:9: warning: return with a value, in function
returning void
return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
pcitest.c: In function main:
pcitest.c:232:9: error: void value not ignored as it ought to be
return run_test(test);
Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/pci/pcitest.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index 8ca1c62bc06d..7002df55826f 100644 --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -42,15 +42,15 @@ struct pci_test { unsigned long size; }; -static void run_test(struct pci_test *test) +static int run_test(struct pci_test *test) { - long ret; + int ret = -EINVAL; int fd; fd = open(test->device, O_RDWR); if (fd < 0) { perror("can't open PCI Endpoint Test device"); - return; + return -ENODEV; } if (test->barnum >= 0 && test->barnum <= 5) { |