summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorMichal Hocko <mhocko@suse.cz>2013-04-30 02:07:18 +0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-04-30 02:54:33 +0400
commit19f39402864ea3935b36ab1066c6283d6ea53f44 (patch)
tree2a073f80c676db471735652122c9ac791adbd9d0 /tools
parent5f57816197186378449b848e99ca9cf41a0055f1 (diff)
downloadlinux-19f39402864ea3935b36ab1066c6283d6ea53f44.tar.xz
memcg: simplify mem_cgroup_iter
The current implementation of mem_cgroup_iter has to consider both css and memcg to find out whether no group has been found (css==NULL - aka the loop is completed) and that no memcg is associated with the found node (!memcg - aka css_tryget failed because the group is no longer alive). This leads to awkward tweaks like tests for css && !memcg to skip the current node. It will be much easier if we got rid off css variable altogether and only rely on memcg. In order to do that the iteration part has to skip dead nodes. This sounds natural to me and as a nice side effect we will get a simple invariant that memcg is always alive when non-NULL and all nodes have been visited otherwise. We could get rid of the surrounding while loop but keep it in for now to make review easier. It will go away in the following patch. Signed-off-by: Michal Hocko <mhocko@suse.cz> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Ying Han <yinghan@google.com> Cc: Tejun Heo <htejun@gmail.com> Cc: Glauber Costa <glommer@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions