diff options
| author | zhujun2 <zhujun2@cmss.chinamobile.com> | 2023-10-18 04:59:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-11-28 19:54:51 +0300 |
| commit | f161a6b11ae7b87aa720eb8636f52f28791ebee9 (patch) | |
| tree | 146e2d0a3984c719c6fe4810dc8b88f0fda55eb4 /tools/testing/selftests | |
| parent | f475d5502f33a6c5b149b0afe96316ad1962a64a (diff) | |
| download | linux-f161a6b11ae7b87aa720eb8636f52f28791ebee9.tar.xz | |
selftests/efivarfs: create-read: fix a resource leak
[ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ]
The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading
Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/testing/selftests')
| -rw-r--r-- | tools/testing/selftests/efivarfs/create-read.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c index 9674a19396a3..7bc7af4eb2c1 100644 --- a/tools/testing/selftests/efivarfs/create-read.c +++ b/tools/testing/selftests/efivarfs/create-read.c @@ -32,8 +32,10 @@ int main(int argc, char **argv) rc = read(fd, buf, sizeof(buf)); if (rc != 0) { fprintf(stderr, "Reading a new var should return EOF\n"); + close(fd); return EXIT_FAILURE; } + close(fd); return EXIT_SUCCESS; } |