diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-06 02:41:44 +0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-06 02:46:47 +0400 |
| commit | 71e7cf3a37ba6189fa7215555e8e760b400fc23b (patch) | |
| tree | 6b0fcb189beca167f8376e9d6ab9b3f598d861ae /tools/perf | |
| parent | 33e26a1b492d21283d1372ddd547562d371dab98 (diff) | |
| download | linux-71e7cf3a37ba6189fa7215555e8e760b400fc23b.tar.xz | |
perf report: Speed up exit path
When cmd_record exits the whole perf binary will exit right after,
so no need to traverse lots of complex data structures freeing them.
Sticked a comment for leak detectives and for a experiment with obstacks
to be performed so that we can speed up freeing that memory.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/builtin-report.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 4a7a74362451..55fc1f46892a 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -348,7 +348,18 @@ static int __cmd_report(void) hists__tty_browse_tree(&session->hists_tree, help); out_delete: - perf_session__delete(session); + /* + * Speed up the exit process, for large files this can + * take quite a while. + * + * XXX Enable this when using valgrind or if we ever + * librarize this command. + * + * Also experiment with obstacks to see how much speed + * up we'll get here. + * + * perf_session__delete(session); + */ return ret; } |