diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2021-06-11 09:33:36 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2021-06-14 15:05:36 +0300 |
| commit | d33b9035e14a35f6f2a5f067f0b156a93581811d (patch) | |
| tree | c1ea88952eeffb4a3b2967108fe769e7369f7f36 /tools/objtool/include | |
| parent | c199f64ff93c48a45add92eee4456ffcabfc838e (diff) | |
| download | linux-d33b9035e14a35f6f2a5f067f0b156a93581811d.tar.xz | |
objtool: Improve reloc hash size guestimate
Nathan reported that LLVM ThinLTO builds have a performance regression
with commit 25cf0d8aa2a3 ("objtool: Rewrite hashtable sizing"). Sami
was quick to note that this is due to their use of -ffunction-sections.
As a result the .text section is small and basing the number of relocs
off of that no longer works. Instead have read_sections() compute the
sum of all SHF_EXECINSTR sections and use that.
Fixes: 25cf0d8aa2a3 ("objtool: Rewrite hashtable sizing")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Debugged-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lkml.kernel.org/r/YMJpGLuGNsGtA5JJ@hirez.programming.kicks-ass.net
Diffstat (limited to 'tools/objtool/include')
| -rw-r--r-- | tools/objtool/include/objtool/elf.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/objtool/include/objtool/elf.h b/tools/objtool/include/objtool/elf.h index 90082751f851..e34395047530 100644 --- a/tools/objtool/include/objtool/elf.h +++ b/tools/objtool/include/objtool/elf.h @@ -83,6 +83,7 @@ struct elf { int fd; bool changed; char *name; + unsigned int text_size; struct list_head sections; int symbol_bits; |