diff options
author | Sean Christopherson <sean.j.christopherson@intel.com> | 2018-08-23 23:56:53 +0300 |
---|---|---|
committer | Radim Krčmář <rkrcmar@redhat.com> | 2018-08-30 17:20:44 +0300 |
commit | c60658d1d983641fcdbb16f86bc2f3806d88bab4 (patch) | |
tree | ef2581bf6e2efe2921d851a4983a6be74df5b22f /tools/kvm | |
parent | 0ce97a2b627c5e26347aee298f571ddf925e5fe4 (diff) | |
download | linux-c60658d1d983641fcdbb16f86bc2f3806d88bab4.tar.xz |
KVM: x86: Unexport x86_emulate_instruction()
Allowing x86_emulate_instruction() to be called directly has led to
subtle bugs being introduced, e.g. not setting EMULTYPE_NO_REEXECUTE
in the emulation type. While most of the blame lies on re-execute
being opt-out, exporting x86_emulate_instruction() also exposes its
cr2 parameter, which may have contributed to commit d391f1207067
("x86/kvm/vmx: do not use vm-exit instruction length for fast MMIO
when running nested") using x86_emulate_instruction() instead of
emulate_instruction() because "hey, I have a cr2!", which in turn
introduced its EMULTYPE_NO_REEXECUTE bug.
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Diffstat (limited to 'tools/kvm')
0 files changed, 0 insertions, 0 deletions