summaryrefslogtreecommitdiff
path: root/tools/include
diff options
context:
space:
mode:
authorJesper Dangaard Brouer <brouer@redhat.com>2021-02-09 16:38:14 +0300
committerDaniel Borkmann <daniel@iogearbox.net>2021-02-13 03:14:08 +0300
commit2c0a10af688c02adcf127aad29e923e0056c6b69 (patch)
treeffe3309649bc3ca4aadfbc18cea554513f05ff6f /tools/include
parent6306c1189e77a513bf02720450bb43bd4ba5d8ae (diff)
downloadlinux-2c0a10af688c02adcf127aad29e923e0056c6b69.tar.xz
bpf: Fix bpf_fib_lookup helper MTU check for SKB ctx
BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size, by adjusting fib_params 'tot_len' with the packet length plus the expected encap size. (Just like the bpf_check_mtu helper supports). He discovered that for SKB ctx the param->tot_len was not used, instead skb->len was used (via MTU check in is_skb_forwardable() that checks against netdev MTU). Fix this by using fib_params 'tot_len' for MTU check. If not provided (e.g. zero) then keep existing TC behaviour intact. Notice that 'tot_len' for MTU check is done like XDP code-path, which checks against FIB-dst MTU. V16: - Revert V13 optimization, 2nd lookup is against egress/resulting netdev V13: - Only do ifindex lookup one time, calling dev_get_by_index_rcu(). V10: - Use same method as XDP for 'tot_len' MTU check Fixes: 4c79579b44b1 ("bpf: Change bpf_fib_lookup to return lookup status") Reported-by: Carlo Carraro <colrack@gmail.com> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/161287789444.790810.15247494756551413508.stgit@firesoul
Diffstat (limited to 'tools/include')
0 files changed, 0 insertions, 0 deletions