diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-01-08 10:43:30 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-13 12:03:51 +0300 |
| commit | 4cdad05eb6f773be68ae6b2686f933033b80f5a4 (patch) | |
| tree | 90f5fef1bcccac556691b35ef288aa3c22a7a5c8 /sound | |
| parent | dbf1c67c19b589312e5d91a549c5ef347e1112fa (diff) | |
| download | linux-4cdad05eb6f773be68ae6b2686f933033b80f5a4.tar.xz | |
ALSA: cs46xx: Potential NULL dereference in probe
commit 1524f4e47f90b27a3ac84efbdd94c63172246a6f upstream.
The "chip->dsp_spos_instance" can be NULL on some of the ealier error
paths in snd_cs46xx_create().
Reported-by: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/cs46xx/dsp_spos.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c index 4a0cbd2241d8..3191666ac129 100644 --- a/sound/pci/cs46xx/dsp_spos.c +++ b/sound/pci/cs46xx/dsp_spos.c @@ -899,6 +899,9 @@ int cs46xx_dsp_proc_done (struct snd_cs46xx *chip) struct dsp_spos_instance * ins = chip->dsp_spos_instance; int i; + if (!ins) + return 0; + snd_info_free_entry(ins->proc_sym_info_entry); ins->proc_sym_info_entry = NULL; |