diff options
| author | Takashi Iwai <tiwai@suse.de> | 2023-01-04 18:09:44 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-01-04 18:10:19 +0300 |
| commit | 16f1f838442dc6430d32d51ddda347b8421ec34b (patch) | |
| tree | e1b99d25b88149978b0214973dc6439188c088ca /sound/usb | |
| parent | 37b3e56d8911f9ec1e1aaa5cccdff33cb0a7a832 (diff) | |
| download | linux-16f1f838442dc6430d32d51ddda347b8421ec34b.tar.xz | |
Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing"
This reverts commit ac5e2fb425e1121ceef2b9d1b3ffccc195d55707.
The commit caused a regression on Behringer UMC404HD (and likely
others). As the change was meant only as a minor optimization, it's
better to revert it to address the regression.
Reported-and-tested-by: Michael Ralston <michael@ralston.id.au>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com
Link: https://lore.kernel.org/r/20230104150944.24918-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb')
| -rw-r--r-- | sound/usb/stream.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sound/usb/stream.c b/sound/usb/stream.c index f75601ca2d52..f10f4e6d3fb8 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1222,6 +1222,12 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, if (err < 0) return err; } + + /* try to set the interface... */ + usb_set_interface(chip->dev, iface_no, 0); + snd_usb_init_pitch(chip, fp); + snd_usb_init_sample_rate(chip, fp, fp->rate_max); + usb_set_interface(chip->dev, iface_no, altno); } return 0; } |