diff options
author | David Flater <dave@flaterco.com> | 2012-08-28 06:25:21 +0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2012-08-28 21:58:12 +0400 |
commit | 1338fc97d07a04e74a7b75ff28b7751061f4cf38 (patch) | |
tree | a9432867f53befa3ce1e63a11144b8ff4b5b6887 /sound/usb/card.h | |
parent | a184d4e4591bb53fd8b91d6e8b85cffa261fb83e (diff) | |
download | linux-1338fc97d07a04e74a7b75ff28b7751061f4cf38.tar.xz |
ALSA: emu8000: fix emu8000 DRAM sized 512 KiB too small
v2: Fixed result still wrong in the case of 512 KiB DRAM. Oops.
Applicable to 3.5.3 mainline.
In emu8000.c, size_dram determines the amount of memory on the sound card by
doing write/readback tests starting at 512 KiB and incrementing by 512 KiB.
On success, detected_size is updated to the successful address and testing
continues. On failure, the loop is immediately exited. The resulting
detected_size is 512 KiB too small except in two special cases:
1. If there is no memory, the initial 0 value of detected_size is used, which
is correct.
2. If the address space wraps around, detected_size is updated before the
bailout, so the result is correct.
The patch corrects all cases and was tested with an AWE64 Gold. Before:
EMU8000 [0x620]: 3584 Kb on-board memory detected
asfxload 4GMGSMT.SF2 (4174814 B) fails.
After:
EMU8000 [0x620]: 4096 Kb on-board memory detected
asfxload 4GMGSMT.SF2 succeeds.
I do not have a card with 512 KiB to test with, but by forcibly enabling the
added conditional I verified on the AWE64 Gold that it detects 512 KiB
(successfully reading from the first memory location) and does not hang the
card.
C.f. Bug 46451 https://bugzilla.kernel.org/show_bug.cgi?id=46451
Signed-off-by: David Flater <dave@flaterco.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/card.h')
0 files changed, 0 insertions, 0 deletions