summaryrefslogtreecommitdiff
path: root/sound/usb/caiaq/midi.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2017-11-06 12:47:14 +0300
committerTakashi Iwai <tiwai@suse.de>2017-11-06 17:03:38 +0300
commitf9a1c372299fed53d4b72bb601f7f3bfe6f9999c (patch)
treead5f56548c727aa8b8773df1f25ab3373e3ad86d /sound/usb/caiaq/midi.c
parent4f95646c803f6a534e58b1d33afbfdaf3e122328 (diff)
downloadlinux-f9a1c372299fed53d4b72bb601f7f3bfe6f9999c.tar.xz
ALSA: usx2y: Fix invalid stream URBs
The us122l driver creates URBs per the fixed endpoints, and this may end up with URBs with inconsistent pipes when a fuzzer or a malicious program deals with the manipulated endpoints. It ends up with a kernel warning like: usb 1-1: BOGUS urb xfer, pipe 0 != type 3 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 24 at drivers/usb/core/urb.c:471 usb_submit_urb+0x113e/0x1400 Call Trace: usb_stream_start+0x48a/0x9f0 sound/usb/usx2y/usb_stream.c:690 us122l_start+0x116/0x290 sound/usb/usx2y/us122l.c:365 us122l_create_card sound/usb/usx2y/us122l.c:502 us122l_usb_probe sound/usb/usx2y/us122l.c:588 .... For avoiding the bad access, this patch adds a few sanity checks of the validity of created URBs like previous similar fixes using the new usb_urb_ep_type_check() helper function. Reported-by: Andrey Konovalov <andreyknvl@google.com> Tested-by: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/caiaq/midi.c')
0 files changed, 0 insertions, 0 deletions