diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2020-08-13 23:01:35 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-08-18 13:50:15 +0300 |
| commit | b66a056e1539d8470013fff00f476377a616baa3 (patch) | |
| tree | a6a8ef66ab21e26351a07c121887c18fca2bdcc1 /sound/soc/intel/atom/sst/sst_loader.c | |
| parent | eeb460f21250d46e5fa8e8429c38de47fe912481 (diff) | |
| download | linux-b66a056e1539d8470013fff00f476377a616baa3.tar.xz | |
ASoC: Intel: Atom: sst_loader: remove always-true condition
Fix cppcheck warning:
sound/soc/intel/atom/sst/sst_loader.c:401:43: style: Redundant
condition: If 'EXPR == 4', the comparison 'EXPR != 3' is always
true. [redundantCondition]
if (sst_drv_ctx->sst_state != SST_RESET ||
^
In this case, if sst_state == SST_SHUTDOWN then the first test is
already true. 2014 bug, yay.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813200147.61990-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/atom/sst/sst_loader.c')
| -rw-r--r-- | sound/soc/intel/atom/sst/sst_loader.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/intel/atom/sst/sst_loader.c b/sound/soc/intel/atom/sst/sst_loader.c index fc91a304256b..5c42cce90ce2 100644 --- a/sound/soc/intel/atom/sst/sst_loader.c +++ b/sound/soc/intel/atom/sst/sst_loader.c @@ -398,8 +398,7 @@ int sst_load_fw(struct intel_sst_drv *sst_drv_ctx) dev_dbg(sst_drv_ctx->dev, "sst_load_fw\n"); - if (sst_drv_ctx->sst_state != SST_RESET || - sst_drv_ctx->sst_state == SST_SHUTDOWN) + if (sst_drv_ctx->sst_state != SST_RESET) return -EAGAIN; if (!sst_drv_ctx->fw_in_mem) { |