diff options
| author | Tom Rix <trix@redhat.com> | 2021-04-30 17:21:17 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-05-10 19:06:06 +0300 |
| commit | 58f01c7fc81baced84f237554d56847e17b5d730 (patch) | |
| tree | 327087ed42d68cbbcb9a2a22fd545bfb204a0e87 /sound/soc/codecs/lpass-wsa-macro.c | |
| parent | 1d122dd3b168f55e2e29982cff80f1c15f66ef26 (diff) | |
| download | linux-58f01c7fc81baced84f237554d56847e17b5d730.tar.xz | |
ASoC: codecs: lpass-wsa-macro: handle unexpected input
Static analysis reports this problem
lpass-wsa-macro.c:1732:6: warning: Array subscript is undefined
if (wsa->ec_hq[ec_tx]) {
^~~~~~~~~~~~~~~~~
The happens because 'ec_tx' is never initialized and there is
no default in switch statement that sets ec_tx. Add a default
case that returns an error before the array is accessed.
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210430142117.3272772-1-trix@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/lpass-wsa-macro.c')
| -rw-r--r-- | sound/soc/codecs/lpass-wsa-macro.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index 1a7fa5492f28..d3ac318fd6b6 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -1727,6 +1727,10 @@ static int wsa_macro_enable_echo(struct snd_soc_dapm_widget *w, val = val & CDC_WSA_RX_MIX_TX1_SEL_MASK; ec_tx = (val >> CDC_WSA_RX_MIX_TX1_SEL_SHFT) - 1; break; + default: + dev_err(component->dev, "%s: Invalid shift %u\n", + __func__, w->shift); + return -EINVAL; } if (wsa->ec_hq[ec_tx]) { |