diff options
| author | Tom Rix <trix@redhat.com> | 2023-02-05 04:57:33 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-02-06 16:12:35 +0300 |
| commit | 983272a2a223de59dbb4cb189aa4d02d7156d209 (patch) | |
| tree | 00743917e2ffffdfc67ec47cef31f57a1d1e5dc6 /sound/soc/codecs/aw88395 | |
| parent | 700ed3bbb7a0bd5eeb805a2c2ba47a6d7b286745 (diff) | |
| download | linux-983272a2a223de59dbb4cb189aa4d02d7156d209.tar.xz | |
ASoC: codecs: aw88395: initialize cur_scene_id to 0
cppcheck reports
sound/soc/codecs/aw88395/aw88395_lib.c:789:6: error: Uninitialized variable: cur_scene_id [uninitvar]
if (cur_scene_id == 0) {
^
Passing a garbage value to aw_dev_parse_data_by_sec_type_v1() will cause a crash
when the value is used as an array index. This check assumes cur_scene_id is
initialized to 0, so initialize it to 0.
Fixes: 4345865b003b ("ASoC: codecs: ACF bin parsing and check library file for aw88395")
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230205015733.1721009-1-trix@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/aw88395')
| -rw-r--r-- | sound/soc/codecs/aw88395/aw88395_lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c index 64dde972f3f0..d7c31a202adc 100644 --- a/sound/soc/codecs/aw88395/aw88395_lib.c +++ b/sound/soc/codecs/aw88395/aw88395_lib.c @@ -769,7 +769,7 @@ static int aw_dev_parse_dev_type_v1(struct aw_device *aw_dev, { struct aw_cfg_dde_v1 *cfg_dde = (struct aw_cfg_dde_v1 *)((char *)prof_hdr + prof_hdr->hdr_offset); - int cur_scene_id; + int cur_scene_id = 0; unsigned int i; int ret; |