summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorCasey Schaufler <casey@schaufler-ca.com>2009-01-28 06:56:30 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-28 07:13:32 +0300
commit152a649b647a8ef47bb74ff9e11850fa6001bedc (patch)
treeea626697e2cbf07f1cba973158b99125e98344ae /security
parente4a7ca29039e615ce13a61b9c6abfb2aa394e9a1 (diff)
downloadlinux-152a649b647a8ef47bb74ff9e11850fa6001bedc.tar.xz
smackfs load append mode fix
Given just how hard it is to find the code that uses MAY_APPEND it's probably not a big surprise that this went unnoticed for so long. The Smack rules loading code is incorrectly setting the MAY_READ bit when MAY_APPEND is requested. Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> Reviewed-by: James Morris <jmorris@namei.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'security')
-rw-r--r--security/smack/smackfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 71e2b914363e..8e42800878f4 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct file *file, const char __user *buf,
break;
case 'a':
case 'A':
- rule.smk_access |= MAY_READ;
+ rule.smk_access |= MAY_APPEND;
break;
default:
goto out;