diff options
author | Jesper Dangaard Brouer <brouer@redhat.com> | 2022-09-21 20:05:32 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-09-26 21:28:19 +0300 |
commit | fb33ec016b8710281343ce73bec92bfe54bad4fa (patch) | |
tree | f471e8b3f7980468c82d5651c112fa620bbb160c /security/commoncap.c | |
parent | c931b060f0939efc2e4c0eeaa5ae8268a7c5c22c (diff) | |
download | linux-fb33ec016b8710281343ce73bec92bfe54bad4fa.tar.xz |
xdp: improve page_pool xdp_return performance
During LPC2022 I meetup with my page_pool co-maintainer Ilias. When
discussing page_pool code we realised/remembered certain optimizations
had not been fully utilised.
Since commit c07aea3ef4d4 ("mm: add a signature in struct page") struct
page have a direct pointer to the page_pool object this page was
allocated from.
Thus, with this info it is possible to skip the rhashtable_lookup to
find the page_pool object in __xdp_return().
The rcu_read_lock can be removed as it was tied to xdp_mem_allocator.
The page_pool object is still safe to access as it tracks inflight pages
and (potentially) schedules final release from a work queue.
Created a micro benchmark of XDP redirecting from mlx5 into veth with
XDP_DROP bpf-prog on the peer veth device. This increased performance
6.5% from approx 8.45Mpps to 9Mpps corresponding to using 7 nanosec
(27 cycles at 3.8GHz) less per packet.
Suggested-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Link: https://lore.kernel.org/r/166377993287.1737053.10258297257583703949.stgit@firesoul
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'security/commoncap.c')
0 files changed, 0 insertions, 0 deletions