diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2021-09-30 01:05:26 +0300 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2021-11-04 01:57:19 +0300 |
| commit | f4a2d282cca57607a0d6718fafa1ab2d62703254 (patch) | |
| tree | 16fb63da1fc76313944707c9be9061f218f81c3c /security/apparmor/policy.c | |
| parent | 4d47fbbe54bf75b72eac3f5a0caa664300937620 (diff) | |
| download | linux-f4a2d282cca57607a0d6718fafa1ab2d62703254.tar.xz | |
apparmor: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security/apparmor/policy.c')
| -rw-r--r-- | security/apparmor/policy.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c index 4da4f3df9d4a..76cc1949c66f 100644 --- a/security/apparmor/policy.c +++ b/security/apparmor/policy.c @@ -259,8 +259,7 @@ struct aa_profile *aa_alloc_profile(const char *hname, struct aa_proxy *proxy, struct aa_profile *profile; /* freed by free_profile - usually through aa_put_profile */ - profile = kzalloc(sizeof(*profile) + sizeof(struct aa_profile *) * 2, - gfp); + profile = kzalloc(struct_size(profile, label.vec, 2), gfp); if (!profile) return NULL; |