diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-02-20 11:18:47 +0300 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-03-25 20:03:57 +0300 |
commit | 9a47ceec543bfb703fbe2f8d584850b582caf1a6 (patch) | |
tree | 565f1ac80d53e33db268d68986055733caca0194 /scripts/kconfig/menu.c | |
parent | 84af7a6194e493fae312a2b7fa5a3b51f76d9282 (diff) | |
download | linux-9a47ceec543bfb703fbe2f8d584850b582caf1a6.tar.xz |
kconfig: clean-up reverse dependency help implementation
This commit splits out the special E_OR handling ('-' instead of '||')
into a dedicated helper expr_print_revdev().
Restore the original expr_print() prior to commit 1ccb27143360
("kconfig: make "Selected by:" and "Implied by:" readable").
This makes sense because:
- We need to chop those expressions only when printing the reverse
dependency, and only when E_OR is encountered
- Otherwise, it should be printed as before, so fall back to
expr_print()
This also improves the behavior; for a single line, it was previously
displayed in the same line as "Selected by", like this:
Selected by: A [=n] && B [=n]
This will be displayed in a new line, consistently:
Selected by:
- A [=n] && B [=n]
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Diffstat (limited to 'scripts/kconfig/menu.c')
-rw-r--r-- | scripts/kconfig/menu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index 36cd3e1f1c28..02f46813e732 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -829,15 +829,15 @@ static void get_symbol_str(struct gstr *r, struct symbol *sym, get_symbol_props_str(r, sym, P_SELECT, _(" Selects: ")); if (sym->rev_dep.expr) { str_append(r, _(" Selected by: ")); - expr_gstr_print_revdep(sym->rev_dep.expr, r); str_append(r, "\n"); + expr_gstr_print_revdep(sym->rev_dep.expr, r); } get_symbol_props_str(r, sym, P_IMPLY, _(" Implies: ")); if (sym->implied.expr) { str_append(r, _(" Implied by: ")); - expr_gstr_print_revdep(sym->implied.expr, r); str_append(r, "\n"); + expr_gstr_print_revdep(sym->implied.expr, r); } str_append(r, "\n\n"); |