diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-02-05 17:29:21 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-02-07 08:05:36 +0400 |
| commit | c6e27f2f3cf2631aae6f1f6fae1a7ab083fdb024 (patch) | |
| tree | ad8c756f552c01b0b853fbd5041310cd1971c9cd /samples | |
| parent | 63b5f152eb4a5bb79b9caf7ec37b4201d12f6e66 (diff) | |
| download | linux-c6e27f2f3cf2631aae6f1f6fae1a7ab083fdb024.tar.xz | |
tg3: cleanup an error path in tg3_phy_reset_5703_4_5()
In the original code, if tg3_readphy() fails then it does an unnecessary
check to verify "err" is still zero and then returns -EBUSY.
My static checker complains about the unnecessary "if (!err)" check and
anyway it is better to propagate the -EBUSY error code from
tg3_readphy() instead of hard coding it here. And really the original
code is confusing to look at.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions