diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-11-03 01:02:36 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-03 14:20:45 +0300 |
| commit | 1aabe578dd86e9f2867c4db4fba9a15f4ba1825d (patch) | |
| tree | 4429f5c426d59b7935ace911ca4e77eb32a133a8 /net | |
| parent | 9b65b17db72313b7a4fe9bc9502928c88be57986 (diff) | |
| download | linux-1aabe578dd86e9f2867c4db4fba9a15f4ba1825d.tar.xz | |
ethtool: fix ethtool msg len calculation for pause stats
ETHTOOL_A_PAUSE_STAT_MAX is the MAX attribute id,
so we need to subtract non-stats and add one to
get a count (IOW -2+1 == -1).
Otherwise we'll see:
ethnl cmd 21: calculated reply length 40, but consumed 52
Fixes: 9a27a33027f2 ("ethtool: add standard pause stats")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ethtool/pause.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ethtool/pause.c b/net/ethtool/pause.c index 9009f412151e..ee1e5806bc93 100644 --- a/net/ethtool/pause.c +++ b/net/ethtool/pause.c @@ -56,8 +56,7 @@ static int pause_reply_size(const struct ethnl_req_info *req_base, if (req_base->flags & ETHTOOL_FLAG_STATS) n += nla_total_size(0) + /* _PAUSE_STATS */ - nla_total_size_64bit(sizeof(u64)) * - (ETHTOOL_A_PAUSE_STAT_MAX - 2); + nla_total_size_64bit(sizeof(u64)) * ETHTOOL_PAUSE_STAT_CNT; return n; } |