diff options
| author | Johnathan Mantey <johnathanx.mantey@intel.com> | 2023-11-13 19:30:29 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-15 12:59:44 +0300 |
| commit | 9e2e7efbbbff69d8340abb56d375dd79d1f5770f (patch) | |
| tree | 1b6d5988fb5494f836c14f7978ccd6c0959a442c /net | |
| parent | a133eae83a1fd614751b1a34752716bad5f6409e (diff) | |
| download | linux-9e2e7efbbbff69d8340abb56d375dd79d1f5770f.tar.xz | |
Revert ncsi: Propagate carrier gain/loss events to the NCSI controller
This reverts commit 3780bb29311eccb7a1c9641032a112eed237f7e3.
The cited commit introduced unwanted behavior.
The intent for the commit was to be able to detect carrier loss/gain
for just the NIC connected to the BMC. The unwanted effect is a
carrier loss for auxiliary paths also causes the BMC to lose
carrier. The BMC never regains carrier despite the secondary NIC
regaining a link.
This change, when merged, needs to be backported to stable kernels.
5.4-stable, 5.10-stable, 5.15-stable, 6.1-stable, 6.5-stable
Fixes: 3780bb29311e ("ncsi: Propagate carrier gain/loss events to the NCSI controller")
CC: stable@vger.kernel.org
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ncsi/ncsi-aen.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index f8854bff286c..62fb1031763d 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -89,11 +89,6 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, if ((had_link == has_link) || chained) return 0; - if (had_link) - netif_carrier_off(ndp->ndev.dev); - else - netif_carrier_on(ndp->ndev.dev); - if (!ndp->multi_package && !nc->package->multi_channel) { if (had_link) { ndp->flags |= NCSI_DEV_RESHUFFLE; |