diff options
| author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2015-04-28 19:33:48 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-04-29 21:59:16 +0300 |
| commit | 821996795973fd52703c35811a03db9fec1ac141 (patch) | |
| tree | ab0891ed0461e7fd13f582d18cc54b641ba18afe /net | |
| parent | 2b70fe5aba0dd00d81173243c7ab04c66aeb67d8 (diff) | |
| download | linux-821996795973fd52703c35811a03db9fec1ac141.tar.xz | |
bridge/mdb: remove wrong use of NLM_F_MULTI
NLM_F_MULTI must be used only when a NLMSG_DONE message is sent. In fact,
it is sent only at the end of a dump.
Libraries like libnl will wait forever for NLMSG_DONE.
Fixes: 37a393bc4932 ("bridge: notify mdb changes via netlink")
CC: Cong Wang <amwang@redhat.com>
CC: Stephen Hemminger <stephen@networkplumber.org>
CC: bridge@lists.linux-foundation.org
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bridge/br_mdb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 409608960899..e29ad70b3000 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -170,7 +170,7 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb, struct br_port_msg *bpm; struct nlattr *nest, *nest2; - nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); + nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0); if (!nlh) return -EMSGSIZE; |