diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2018-04-07 03:19:41 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-04-12 13:31:19 +0300 |
| commit | a61bf7ba7f9f7bff39720508b136a9f22966e2af (patch) | |
| tree | 1684c60f782636c13113ab816d6ba44c95f47ab5 /net | |
| parent | 8c09a81ed1b93982cdc9747decd155b6300ad3a9 (diff) | |
| download | linux-a61bf7ba7f9f7bff39720508b136a9f22966e2af.tar.xz | |
net_sched: fix a missing idr_remove() in u32_delete_key()
[ Upstream commit f12c643209db0626f2f54780d86bb93bfa7a9c2d ]
When we delete a u32 key via u32_delete_key(), we forget to
call idr_remove() to remove its handle from IDR.
Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles")
Reported-by: Marcin Kabiesz <admin@hostcenter.eu>
Tested-by: Marcin Kabiesz <admin@hostcenter.eu>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/cls_u32.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 425cc341fd41..8d25f38cc1ad 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -478,6 +478,7 @@ static int u32_delete_key(struct tcf_proto *tp, struct tc_u_knode *key) RCU_INIT_POINTER(*kp, key->next); tcf_unbind_filter(tp, &key->res); + idr_remove(&ht->handle_idr, key->handle); tcf_exts_get_net(&key->exts); call_rcu(&key->rcu, u32_delete_key_freepf_rcu); return 0; |