diff options
| author | Yuhao Jiang <danisjiang@gmail.com> | 2025-06-23 12:48:44 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-08-15 13:17:08 +0300 |
| commit | 57ecbd4a50a498732adbd0011d18b4d39595dead (patch) | |
| tree | cf8ffe753f75fca8ecd5b8824c6a24555efbc763 /net/unix/sysctl_net_unix.c | |
| parent | 7e15d1eaa88179c5185e57a38ab05fe852d0cb8d (diff) | |
| download | linux-57ecbd4a50a498732adbd0011d18b4d39595dead.tar.xz | |
USB: gadget: f_hid: Fix memory leak in hidg_bind error path
commit 62783c30d78aecf9810dae46fd4d11420ad38b74 upstream.
In hidg_bind(), if alloc_workqueue() fails after usb_assign_descriptors()
has successfully allocated the USB descriptors, the current error handling
does not call usb_free_all_descriptors() to free the allocated descriptors,
resulting in a memory leak.
Restructure the error handling by adding proper cleanup labels:
- fail_free_all: cleans up workqueue and descriptors
- fail_free_descs: cleans up descriptors only
- fail: original cleanup for earlier failures
This ensures that allocated resources are properly freed in reverse order
of their allocation, preventing the memory leak when alloc_workqueue() fails.
Fixes: a139c98f760ef ("USB: gadget: f_hid: Add GET_REPORT via userspace IOCTL")
Cc: stable@vger.kernel.org
Signed-off-by: Yuhao Jiang <danisjiang@gmail.com>
Link: https://lore.kernel.org/r/20250623094844.244977-1-danisjiang@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions
