diff options
author | Baptiste Lepers <baptiste.lepers@gmail.com> | 2021-05-01 07:10:51 +0300 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2021-05-02 02:42:14 +0300 |
commit | f8f7e0fb22b2e75be55f2f0c13e229e75b0eac07 (patch) | |
tree | e0c29141e3a872cc35cdb8d12f7381476aea3e70 /net/sunrpc/xprtrdma | |
parent | d9092b4bb2109502eb8972021a3f74febc931a63 (diff) | |
download | linux-f8f7e0fb22b2e75be55f2f0c13e229e75b0eac07.tar.xz |
sunrpc: Fix misplaced barrier in call_decode
Fix a misplaced barrier in call_decode. The struct rpc_rqst is modified
as follows by xprt_complete_rqst:
req->rq_private_buf.len = copied;
/* Ensure all writes are done before we update */
/* req->rq_reply_bytes_recvd */
smp_wmb();
req->rq_reply_bytes_recvd = copied;
And currently read as follows by call_decode:
smp_rmb(); // misplaced
if (!req->rq_reply_bytes_recvd)
goto out;
req->rq_rcv_buf.len = req->rq_private_buf.len;
This patch places the smp_rmb after the if to ensure that
rq_reply_bytes_recvd and rq_private_buf.len are read in order.
Fixes: 9ba828861c56a ("SUNRPC: Don't try to parse incomplete RPC messages")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'net/sunrpc/xprtrdma')
0 files changed, 0 insertions, 0 deletions