diff options
| author | Xin Long <lucien.xin@gmail.com> | 2021-01-15 12:36:39 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-01-17 06:05:59 +0300 |
| commit | 1fef8544bf41fb77d6603feb9a31cd76b4578489 (patch) | |
| tree | 35f127d43a7ff29fe266342bb55d0b9d396dad38 /net/sctp/offload.c | |
| parent | dbd50f238decfe58d2eac4980681a1e62a35c5b5 (diff) | |
| download | linux-1fef8544bf41fb77d6603feb9a31cd76b4578489.tar.xz | |
sctp: remove the NETIF_F_SG flag before calling skb_segment
It makes more sense to clear NETIF_F_SG instead of set it when
calling skb_segment() in sctp_gso_segment(), since SCTP GSO is
using head_skb's fraglist, of which all frags are linear skbs.
This will make SCTP GSO code more understandable.
Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sctp/offload.c')
| -rw-r--r-- | net/sctp/offload.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/offload.c b/net/sctp/offload.c index ce281a9a2875..eb874e3c399a 100644 --- a/net/sctp/offload.c +++ b/net/sctp/offload.c @@ -68,7 +68,7 @@ static struct sk_buff *sctp_gso_segment(struct sk_buff *skb, goto out; } - segs = skb_segment(skb, features | NETIF_F_HW_CSUM | NETIF_F_SG); + segs = skb_segment(skb, (features | NETIF_F_HW_CSUM) & ~NETIF_F_SG); if (IS_ERR(segs)) goto out; |