diff options
author | Daniel Borkmann <daniel@iogearbox.net> | 2016-04-16 03:27:58 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-04-16 06:20:11 +0300 |
commit | 9241e2df4fbc648a92ea0752918e05c26255649e (patch) | |
tree | a4140463f6cdb8ac8471238b1dc59130258f559d /net/rds | |
parent | cfe255600154f0072d4a8695590dbd194dfd1aeb (diff) | |
download | linux-9241e2df4fbc648a92ea0752918e05c26255649e.tar.xz |
vlan: pull on __vlan_insert_tag error path and fix csum correction
When __vlan_insert_tag() fails from skb_vlan_push() path due to the
skb_cow_head(), we need to undo the __skb_push() in the error path
as well that was done earlier to move skb->data pointer to mac header.
Moreover, I noticed that when in the non-error path the __skb_pull()
is done and the original offset to mac header was non-zero, we fixup
from a wrong skb->data offset in the checksum complete processing.
So the skb_postpush_rcsum() really needs to be done before __skb_pull()
where skb->data still points to the mac header start and thus operates
under the same conditions as in __vlan_insert_tag().
Fixes: 93515d53b133 ("net: move vlan pop/push functions into common code")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
0 files changed, 0 insertions, 0 deletions