summaryrefslogtreecommitdiff
path: root/net/nfc
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2021-05-14 17:24:48 +0300
committerDavid S. Miller <davem@davemloft.net>2021-05-17 23:51:35 +0300
commit31db0dbd72444abe645d90c20ecb84d668f5af5e (patch)
treee5775d99dc39b62639cde7b551e80e090aaa5f11 /net/nfc
parentb7df21cf1b79ab7026f545e7bf837bd5750ac026 (diff)
downloadlinux-31db0dbd72444abe645d90c20ecb84d668f5af5e.tar.xz
net: hso: check for allocation failure in hso_create_bulk_serial_device()
In current kernels, small allocations never actually fail so this patch shouldn't affect runtime. Originally this error handling code written with the idea that if the "serial->tiocmget" allocation failed, then we would continue operating instead of bailing out early. But in later years we added an unchecked dereference on the next line. serial->tiocmget->serial_state_notification = kzalloc(); ^^^^^^^^^^^^^^^^^^ Since these allocations are never going fail in real life, this is mostly a philosophical debate, but I think bailing out early is the correct behavior that the user would want. And generally it's safer to bail as soon an error happens. Fixes: af0de1303c4e ("usb: hso: obey DMA rules in tiocmget") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Johan Hovold <johan@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/nfc')
0 files changed, 0 insertions, 0 deletions