summaryrefslogtreecommitdiff
path: root/net/netlink
diff options
context:
space:
mode:
authorIan Schram <ischram@telenet.be>2008-07-22 00:19:35 +0400
committerDavid S. Miller <davem@davemloft.net>2008-07-22 00:19:35 +0400
commit3a33cc108d11fab2a2544e2601066ba4924736aa (patch)
treef5772a2cb5d33ba43fbec8732e04953ace2c5ef5 /net/netlink
parent5547cd0ae8b46db9a084505239294eed9b8c8e2d (diff)
downloadlinux-3a33cc108d11fab2a2544e2601066ba4924736aa.tar.xz
mac80211_hwsim.c: fix: BUG: unable to handle kernel NULL pointer dereference at 0000000000000370
I was looking at this out of interest, but I'm in no way familiar with the code. Looks to me that the error handling code in mac80211_hwsim is awkward. Which leads to it calling ieee80211_unregister_hw even when ieee80211_register_hw failed. The function has a for loop where it generates all simulated radios. when something fails, the error handling will call mac80211_hwsim_free which frees all simulated radios who's pointer isn't zero. However the information stored is insufficient to determine whether or not the call to ieee80211_register_hw succeeded or not for a specific radio. The included patch makes init_mac80211_hwsim clean up the current simulated radio, and then calls into mac80211_hwsim_free to clean up all the radios that did succeed. This however doesn't explain why the rate control registration failed.. build tested this, but had some problems reproducing the original problem. Signed-off-by: Ian Schram <ischram@telenet.be> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink')
0 files changed, 0 insertions, 0 deletions