diff options
| author | Eric Biggers <ebiggers@google.com> | 2019-10-07 00:24:26 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 16:46:49 +0300 |
| commit | e39340636dd980978224755f7bb641eeb08b88f4 (patch) | |
| tree | 5b9ea5a61bc592b712af1b52b8a21d189eed111c /net/llc/llc_conn.c | |
| parent | 05c2aa29d3a4e6d88015cecf04085d4b13ec1ae2 (diff) | |
| download | linux-e39340636dd980978224755f7bb641eeb08b88f4.tar.xz | |
llc: fix another potential sk_buff leak in llc_ui_sendmsg()
[ Upstream commit fc8d5db10cbe1338a52ebc74e7feab9276721774 ]
All callers of llc_conn_state_process() except llc_build_and_send_pkt()
(via llc_ui_sendmsg() -> llc_ui_send_data()) assume that it always
consumes a reference to the skb. Fix this caller to do the same.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/llc/llc_conn.c')
| -rw-r--r-- | net/llc/llc_conn.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/llc/llc_conn.c b/net/llc/llc_conn.c index 444c13e752a0..7340f23e16de 100644 --- a/net/llc/llc_conn.c +++ b/net/llc/llc_conn.c @@ -55,6 +55,8 @@ int sysctl_llc2_busy_timeout = LLC2_BUSY_TIME * HZ; * (executing it's actions and changing state), upper layer will be * indicated or confirmed, if needed. Returns 0 for success, 1 for * failure. The socket lock has to be held before calling this function. + * + * This function always consumes a reference to the skb. */ int llc_conn_state_process(struct sock *sk, struct sk_buff *skb) { |